The following document contains the results of FindBugs Report
FindBugs Version is 2.0.3
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of types at line 365 of value previously dereferenced in gboat2.attachment.AttachmentHelper.findAttachsJsonByAttachNames(String, String[][]) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 363 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class gboat2.attachment.action.AttachConfigAction defines non-transient non-serializable instance field attachConfigBusiness | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class gboat2.attachment.action.AttachConfigAction defines non-transient non-serializable instance field moduleList | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
| Class gboat2.attachment.action.AttachConfigAction defines non-transient non-serializable instance field moduleService | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| originalName could be null and is guaranteed to be dereferenced in gboat2.attachment.action.UploadAction.download() | CORRECTNESS | NP_GUARANTEED_DEREF | 222 | Medium |
| Class gboat2.attachment.action.UploadAction defines non-transient non-serializable instance field uploadService | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gboat2.attachment.model.Attachment.getUploadDate() may expose internal representation by returning Attachment.uploadDate | MALICIOUS_CODE | EI_EXPOSE_REP | 183 | Medium |
| gboat2.attachment.model.Attachment.setUploadDate(Date) may expose internal representation by storing an externally mutable object into Attachment.uploadDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 187 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gboat2.attachment.model.DownloadRecord.getDownloadDate() may expose internal representation by returning DownloadRecord.downloadDate | MALICIOUS_CODE | EI_EXPOSE_REP | 101 | Medium |
| gboat2.attachment.model.DownloadRecord.setDownloadDate(Date) may expose internal representation by storing an externally mutable object into DownloadRecord.downloadDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 105 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class gboat2.attachment.model.TypedAttachments defines non-transient non-serializable instance field types | BAD_PRACTICE | SE_BAD_FIELD | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of att at line 365 of value previously dereferenced in gboat2.attachment.service.impl.AttachmentServiceImpl.generateAttachment(byte[], String, String, String, String, AttachmentOperEnum) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 354 | Medium |
| Exceptional return value of java.io.File.delete() ignored in gboat2.attachment.service.impl.AttachmentServiceImpl.deleteRealFile(String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 79 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gboat2.attachment.util.ConfigUtil.props isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 48 | High |
| gboat2.attachment.util.ConfigUtil.<static initializer for ConfigUtil>() may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 66 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| gboat2.attachment.util.MD5Util.getFileMD5String(File) may fail to clean up java.io.InputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 41 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on Throwable.getStackTrace() in gboat2.attachment.watermark.JMagickWatermarkStrategy.watermark(String, String, String) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 88 | Medium |
