FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.3

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
99 40 0 0

Files

Class Bugs
gboat2.base.core.Activator 5
gboat2.base.core.GBoatClassLoader 1
gboat2.base.core.logging.BusinessLogEntry 2
gboat2.base.core.model.ContentMetadata 4
gboat2.base.core.model.Module 4
gboat2.base.core.model.Opera 3
gboat2.base.core.service.ParameterServiceImpl 1
gboat2.base.core.util.JsonUtil 2
gboat2.base.core.util.JsonVelocityUtil 2
gboat2.base.core.util.SpringContextUtil 3
gboat2.base.core.util.json.GboatJsonBigDecimalValueProcessor 1
gboat2.base.core.util.json.GboatJsonEnumValueProcessor 1
gboat2.base.core.util.json.GboatJsonFloatValueProcessor 1
gboat2.base.core.validate.PrivilegeCheckServiceFactory 2
gboat2.base.core.web.BaseActionSupport 1
gboat2.base.core.web.MetadataSupportStrategy 4
gboat2.base.core.web.ObtainOthers 1
gboat2.base.core.web.md.ExtendMethodHandler 1
gboat2.base.core.web.md.MetadataHandler 1

gboat2.base.core.Activator

Bug Category Details Line Priority
gboat2.base.core.Activator.LOCAL_BUNDLE isn't final and can't be protected from malicious code MALICIOUS_CODE MS_CANNOT_BE_FINAL Medium
gboat2.base.core.Activator.pomCache isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 64 High
gboat2.base.core.Activator.getPkgForBundle(Bundle) may fail to clean up java.io.InputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 162 Medium
gboat2.base.core.Activator.getPkgForBundle(Bundle) may fail to close stream BAD_PRACTICE OS_OPEN_STREAM 137 Medium
Write to static field gboat2.base.core.Activator.LOCAL_BUNDLE from instance method gboat2.base.core.Activator.start(BundleContext) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 72 Medium

gboat2.base.core.GBoatClassLoader

Bug Category Details Line Priority
gboat2.base.core.GBoatClassLoader.<static initializer for GBoatClassLoader>() creates a gboat2.base.core.GBoatClassLoader classloader, which should be performed within a doPrivileged block MALICIOUS_CODE DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED 17 Medium

gboat2.base.core.logging.BusinessLogEntry

Bug Category Details Line Priority
gboat2.base.core.logging.BusinessLogEntry.getOperationTime() may expose internal representation by returning BusinessLogEntry.operationTime MALICIOUS_CODE EI_EXPOSE_REP 123 Medium
gboat2.base.core.logging.BusinessLogEntry.setOperationTime(Date) may expose internal representation by storing an externally mutable object into BusinessLogEntry.operationTime MALICIOUS_CODE EI_EXPOSE_REP2 127 Medium

gboat2.base.core.model.ContentMetadata

Bug Category Details Line Priority
gboat2.base.core.model.ContentMetadata.getCreateTime() may expose internal representation by returning ContentMetadata.createTime MALICIOUS_CODE EI_EXPOSE_REP 103 Medium
gboat2.base.core.model.ContentMetadata.getModifyTime() may expose internal representation by returning ContentMetadata.modifyTime MALICIOUS_CODE EI_EXPOSE_REP 123 Medium
gboat2.base.core.model.ContentMetadata.setCreateTime(Date) may expose internal representation by storing an externally mutable object into ContentMetadata.createTime MALICIOUS_CODE EI_EXPOSE_REP2 116 Medium
gboat2.base.core.model.ContentMetadata.setModifyTime(Date) may expose internal representation by storing an externally mutable object into ContentMetadata.modifyTime MALICIOUS_CODE EI_EXPOSE_REP2 127 Medium

gboat2.base.core.model.Module

Bug Category Details Line Priority
Equals method for gboat2.base.core.model.Module assumes the argument is of type Module BAD_PRACTICE BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS 158 Medium
gboat2.base.core.model.Module.getParams() may expose internal representation by returning Module.params MALICIOUS_CODE EI_EXPOSE_REP 182 Medium
gboat2.base.core.model.Module defines equals and uses Object.hashCode() BAD_PRACTICE HE_EQUALS_USE_HASHCODE 158 High
gboat2.base.core.model.Module.equals(Object) does not check for null argument BAD_PRACTICE NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT 158 Medium

gboat2.base.core.model.Opera

Bug Category Details Line Priority
Equals method for gboat2.base.core.model.Opera assumes the argument is of type Opera BAD_PRACTICE BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS 157 Medium
gboat2.base.core.model.Opera defines equals and uses Object.hashCode() BAD_PRACTICE HE_EQUALS_USE_HASHCODE 157 High
gboat2.base.core.model.Opera.equals(Object) does not check for null argument BAD_PRACTICE NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT 157 Medium

gboat2.base.core.service.ParameterServiceImpl

Bug Category Details Line Priority
Dead store to json in gboat2.base.core.service.ParameterServiceImpl.getParameter(String) STYLE DLS_DEAD_LOCAL_STORE 32 Medium

gboat2.base.core.util.JsonUtil

Bug Category Details Line Priority
Redundant nullcheck of methodes, which is known to be non-null in gboat2.base.core.util.JsonUtil.parse(JSONObject, Class) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 240 Medium
Redundant nullcheck of methodes, which is known to be non-null in gboat2.base.core.util.JsonUtil.parseJSONArray(String, Class) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 188 Medium

gboat2.base.core.util.JsonVelocityUtil

Bug Category Details Line Priority
Incorrect lazy initialization and update of static field gboat2.base.core.util.JsonVelocityUtil.velocityProperties in gboat2.base.core.util.JsonVelocityUtil.fillJsonByVelocityfromMdStr(String, Map) MT_CORRECTNESS LI_LAZY_INIT_UPDATE_STATIC 62 High
Possible null pointer dereference of buf in gboat2.base.core.util.JsonVelocityUtil.getMetadataFile(URL) on exception path CORRECTNESS NP_NULL_ON_SOME_PATH_EXCEPTION 114 Medium

gboat2.base.core.util.SpringContextUtil

Bug Category Details Line Priority
instanceof will always return true for all nonnull values in gboat2.base.core.util.SpringContextUtil.getBeanOfId(String, Bundle), since all org.springframework.osgi.context.support.OsgiBundleXmlApplicationContext are instances of org.springframework.osgi.context.support.OsgiBundleXmlApplicationContext STYLE BC_VACUOUS_INSTANCEOF 208 Medium
instanceof will always return true for all nonnull values in gboat2.base.core.util.SpringContextUtil.getBeansOfType(Class, Bundle), since all org.springframework.osgi.context.support.OsgiBundleXmlApplicationContext are instances of org.springframework.osgi.context.support.OsgiBundleXmlApplicationContext STYLE BC_VACUOUS_INSTANCEOF 121 Medium
gboat2.base.core.util.SpringContextUtil.getBeansOfType(Class, Bundle) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 139 Medium

gboat2.base.core.util.json.GboatJsonBigDecimalValueProcessor

Bug Category Details Line Priority
Impossible cast from java.math.BigDecimal[] to String[] in gboat2.base.core.util.json.GboatJsonBigDecimalValueProcessor.processArrayValue(Object, JsonConfig) CORRECTNESS BC_IMPOSSIBLE_CAST 41 High

gboat2.base.core.util.json.GboatJsonEnumValueProcessor

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in gboat2.base.core.util.json.GboatJsonEnumValueProcessor.processObjectValue(String, Object, JsonConfig) STYLE REC_CATCH_EXCEPTION 51 Medium

gboat2.base.core.util.json.GboatJsonFloatValueProcessor

Bug Category Details Line Priority
Impossible cast from Float[] to String[] in gboat2.base.core.util.json.GboatJsonFloatValueProcessor.processArrayValue(Object, JsonConfig) CORRECTNESS BC_IMPOSSIBLE_CAST 24 High

gboat2.base.core.validate.PrivilegeCheckServiceFactory

Bug Category Details Line Priority
Write to static field gboat2.base.core.validate.PrivilegeCheckServiceFactory.dataPriviTracker from instance method new gboat2.base.core.validate.PrivilegeCheckServiceFactory() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 73 Medium
Write to static field gboat2.base.core.validate.PrivilegeCheckServiceFactory.operaPriviTracker from instance method new gboat2.base.core.validate.PrivilegeCheckServiceFactory() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 52 Medium

gboat2.base.core.web.BaseActionSupport

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in gboat2.base.core.web.BaseActionSupport.getDomainClassAnnotationed() STYLE REC_CATCH_EXCEPTION 309 Medium

gboat2.base.core.web.MetadataSupportStrategy

Bug Category Details Line Priority
Dead store to jsonConf in gboat2.base.core.web.MetadataSupportStrategy.decorateWithData(boolean, JSONObject, String, BaseActionSupport, JSONObject) STYLE DLS_DEAD_LOCAL_STORE 177 Medium
gboat2.base.core.web.MetadataSupportStrategy.logger isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 72 High
Redundant nullcheck of method, which is known to be non-null in gboat2.base.core.web.MetadataSupportStrategy.callInitInvokedMethod(String, BaseActionSupport) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 426 Medium
Exception is caught when Exception is not thrown in gboat2.base.core.web.MetadataSupportStrategy.getActionPropertiesValues(BaseActionSupport, Map, boolean) STYLE REC_CATCH_EXCEPTION 554 Medium

gboat2.base.core.web.ObtainOthers

Bug Category Details Line Priority
Dead store to returned in gboat2.base.core.web.ObtainOthers.getMetadata(String, String, BaseActionSupport) STYLE DLS_DEAD_LOCAL_STORE 29 Medium

gboat2.base.core.web.md.ExtendMethodHandler

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in gboat2.base.core.web.md.ExtendMethodHandler.getFile(String, BaseActionSupport, Bundle) STYLE REC_CATCH_EXCEPTION 35 Medium

gboat2.base.core.web.md.MetadataHandler

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in gboat2.base.core.web.md.MetadataHandler.getActionPropertiesValues(BaseActionSupport, Map, boolean) STYLE REC_CATCH_EXCEPTION 160 Medium