The following document contains the results of FindBugs Report
FindBugs Version is 2.0.3
Threshold is medium
Effort is min
Class | Bugs |
---|---|
gboat2.report.action.ReportConfigAction | 7 |
gboat2.report.model.ReportConfig | 2 |
gboat2.report.service.impl.ReportConfigServiceImpl | 2 |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gboat2.report.action.ReportConfigAction.getAttachids() may expose internal representation by returning ReportConfigAction.attachids | MALICIOUS_CODE | EI_EXPOSE_REP | 83 | Medium |
gboat2.report.action.ReportConfigAction.setAttachids(String[]) may expose internal representation by storing an externally mutable object into ReportConfigAction.attachids | MALICIOUS_CODE | EI_EXPOSE_REP2 | 79 | Medium |
gboat2.report.action.ReportConfigAction.writeFileToDisk(File[], File) may fail to clean up java.io.InputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 250 | Medium |
gboat2.report.action.ReportConfigAction.writeFileToDisk(File[], File) may fail to clean up java.io.OutputStream on checked exception | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE | 251 | Medium |
Exceptional return value of java.io.File.delete() ignored in gboat2.report.action.ReportConfigAction.ajaxDelete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 284 | Medium |
Class gboat2.report.action.ReportConfigAction defines non-transient non-serializable instance field logger | BAD_PRACTICE | SE_BAD_FIELD | Medium | |
Class gboat2.report.action.ReportConfigAction defines non-transient non-serializable instance field urllist | BAD_PRACTICE | SE_BAD_FIELD | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
gboat2.report.model.ReportConfig.getOperationTime() may expose internal representation by returning ReportConfig.operationTime | MALICIOUS_CODE | EI_EXPOSE_REP | 93 | Medium |
gboat2.report.model.ReportConfig.setOperationTime(Date) may expose internal representation by storing an externally mutable object into ReportConfig.operationTime | MALICIOUS_CODE | EI_EXPOSE_REP2 | 97 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The method name gboat2.report.service.impl.ReportConfigServiceImpl.InitAttachsJson() doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 11 | Medium |
The method name gboat2.report.service.impl.ReportConfigServiceImpl.InitUrllist() doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 17 | Medium |